Skip to content

Removed 1 unnecessary stubbing in AutofilledNetworkConfigurationTest.java #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ARUS2023 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Removed 1 unnecessary stubbing in AutofilledNetworkConfigurationTest.java #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...est/java/com/google/jenkins/plugins/computeengine/AutofilledNetworkConfigurationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public void testDoCheckNetworkItemsValid() {

@Test
public void testDoFillSubnetworkItemsEmptyRegion() throws IOException {
DescriptorImpl descriptor = subnetworkFillDescriptorSetup(ImmutableList.of(SUBNETWORK_NAME));
DescriptorImpl descriptor = subnetworkFillDescriptorSetup2(ImmutableList.of(SUBNETWORK_NAME));
ListBoxModel got =
descriptor.doFillSubnetworkItems(r.jenkins, "", "", PROJECT_ID, CREDENTIALS_ID);
Assert.assertEquals(0, got.size());
Expand Down Expand Up @@ -160,4 +160,14 @@ private DescriptorImpl subnetworkFillDescriptorSetup(List<String> subnetworkName
DescriptorImpl.setComputeClient(computeClient);
return new DescriptorImpl();
}

private DescriptorImpl subnetworkFillDescriptorSetup2(List<String> subnetworkNames)
throws IOException {
List<Subnetwork> subnetworks = new ArrayList<>();
subnetworkNames.forEach(
subnet -> subnetworks.add(new Subnetwork().setName(subnet).setSelfLink(subnet)));
ComputeClient computeClient = Mockito.mock(ComputeClient.class);
DescriptorImpl.setComputeClient(computeClient);
return new DescriptorImpl();
}
}