Add userinfo-email OAuth2 scope when associating service account#477
Open
minhluantran017 wants to merge 3 commits intojenkinsci:developfrom
Open
Add userinfo-email OAuth2 scope when associating service account#477minhluantran017 wants to merge 3 commits intojenkinsci:developfrom
minhluantran017 wants to merge 3 commits intojenkinsci:developfrom
Conversation
Author
|
Hi @evandbrown , @craigdbarber , @jtnord , @olamy , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
Service account associating with Jenkins agents provisioned by GCE plugin does not have the scope
userinfo-email, which is suggested by official GKE docs to configure RBAC for the service account to deploy to GKE.Proposal:
Add the
userinfo-emailOAuth2 scope beside currentcloud-platformscope.Github issue:
#476
Testing done
Local unit test passed using
maven:3.8.6-openjdk-11: