Upgrade to use jcasc test harness#80
Merged
Merged
Conversation
Contributor
|
@timja Just to clarify, you'd like us to release a new version of this plugin after these changes? |
Member
Author
|
Hi, ideally may not be required in this case as I don’t think it’s covered by PCT, it was picked up by a search of plugins using configuration-as-code. But a release will be required for the docs migration to be picked up. |
stephenashank
approved these changes
Jan 30, 2020
Contributor
stephenashank
left a comment
stephenashank
left a comment
There was a problem hiding this comment.
Verified that there aren't conflicts with existing plugins when installing the hpi file manually.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JCasc had to create a new dependency that wasn't a
testsclassifier because maven doesn't allow you to bring dependencies through classifiers.Upgrading here so that PCT works again.
Tracking:
jenkinsci/bom#164
Note: We'll need a release for PCT please