Fix NPE when deleting a JClouds node. #218
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a JClouds node that was restored from disk after a jenkins restart, hudson.model.Slave.drainLabelsToTrim() failed with an NPE, because previouslyAssignedLabels was NULL. Reason for that was: JCLoudsSlave provided a readResolve() which did not override. Therefore, hudson.model.Slave.readResolve() was never called when reloading from disk.
This PR adds an
@Overrideand an invocation of super.readResolve() which initializes previouslyAssignedLabels.Testing done
Manually create a JClouds node, then restart jenkins, then delete that node.
Submitter checklist