-
-
Notifications
You must be signed in to change notification settings - Fork 293
fix: temporarilly shadow upstream UriUtil class to fix the upstream bug #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
adca89b
7ad9c57
42cc9c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,44 @@ | ||||||||||||||
| /* | ||||||||||||||
| * Copyright (C) 2014 Atlassian | ||||||||||||||
| * | ||||||||||||||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||||||||
| * you may not use this file except in compliance with the License. | ||||||||||||||
| * You may obtain a copy of the License at | ||||||||||||||
| * | ||||||||||||||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||||||||||||||
| * | ||||||||||||||
| * Unless required by applicable law or agreed to in writing, software | ||||||||||||||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||||||||||||||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||||||||
| * See the License for the specific language governing permissions and | ||||||||||||||
| * limitations under the License. | ||||||||||||||
| */ | ||||||||||||||
|
|
||||||||||||||
| /* Temporary fix until https://bitbucket.org/atlassian/jira-rest-java-client/pull-requests/170 is fixed */ | ||||||||||||||
|
|
||||||||||||||
| package com.atlassian.jira.rest.client.api.domain.util; | ||||||||||||||
|
|
||||||||||||||
| import java.net.URI; | ||||||||||||||
| import java.util.List; | ||||||||||||||
|
|
||||||||||||||
| public class UriUtil { | ||||||||||||||
|
|
||||||||||||||
| private static final List<String> CLOUD_DOMAINS = List.of("atlassian.net", "jira.com", "api.atlassian.com"); | ||||||||||||||
| private static final List<String> DC_DOMAINS = List.of("localhost"); | ||||||||||||||
|
||||||||||||||
|
|
||||||||||||||
| public static URI path(final URI uri, final String path) { | ||||||||||||||
| final String uriString = uri.toString(); | ||||||||||||||
| final StringBuilder sb = new StringBuilder(uriString); | ||||||||||||||
| if (!uriString.endsWith("/")) { | ||||||||||||||
| sb.append('/'); | ||||||||||||||
| } | ||||||||||||||
| sb.append(path.startsWith("/") ? path.substring(1) : path); | ||||||||||||||
| return URI.create(sb.toString()); | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| public static boolean isURICloud(URI uri) { | ||||||||||||||
| String host = uri.getHost().toLowerCase(); | ||||||||||||||
|
||||||||||||||
| String host = uri.getHost().toLowerCase(); | |
| String host = uri.getHost(); | |
| if (host == null) { | |
| return false; | |
| } | |
| host = host.toLowerCase(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The utility class lacks class-level and method-level documentation. Public methods should have Javadoc explaining their parameters, return values, and behavior, especially edge cases (e.g., what happens with null inputs, relative URIs, or URIs without hosts).