Fix queue metrics visibility under restricted ACL contexts#1240
Conversation
Wrap queue item collection in SYSTEM ACL for metrics callback so restricted anonymous contexts do not force jenkins.queue.count statuses to 0. Add a regression test for issue jenkinsci#1174 that verifies anonymous queue visibility is empty while metrics collection sees queued items.
|
Great fix @Flamki! Wrapping queue item reads in ACL.SYSTEM2 is exactly A few observations:
All CI checks passing including 235 tests on Linux. This looks ready |
What problem does this solve?
jenkins.queue.countcan report0for all statuses when queue metrics are collected in a restricted security context (for example anonymous context in hardened Jenkins setups). This hides queued/stuck items even though they are present in Jenkins UI/API.This change wraps queue item reads for metric collection in
ACL.SYSTEM2so queue gauges are based on full queue visibility.Fixes #1174.
How to test the change
./mvnw spotless:check./mvnw test -Dtest=MonitoringQueueListenerTest./mvnw spotbugs:checkBreaking changes
None.
Additional notes
A regression test (
MonitoringQueueListenerTest) verifies that: