Fix Grafana explore URL generation and add Tempo datasource UID support#1250
Fix Grafana explore URL generation and add Tempo datasource UID support#1250somiljain2006 wants to merge 11 commits into
Conversation
|
@kuisathaverat Can you please review this pr? |
|
Did you test it on Grafana? Which version? |
|
@kuisathaverat, thanks for taking a look at this. I verified that when clicking “View pipeline with Grafana”, Grafana correctly opens the explore page and preserves the traceId. Regarding the breaking change concern, this should remain backward compatible. I added explicit fallback logic if a user hasn't configured the new tempoDataSourceUid, the plugin automatically falls back to using their existing tempoDataSourceIdentifier. I also added a specific unit test (testTraceUrlFallbackToIdentifier) about this. Without this change, Grafana rewrites the old explore URL format and drops the traceId. This update aligns the generated URL with the current Grafana explore URL structure so the traceId is preserved. |
|
@kuisathaverat, I have applied the requested changes. Can you please review it? |
|
Great work on this fix @somiljain2006! The migration from the legacy A few observations after reviewing the changes:
All CI checks passing including 240 tests on Linux. |
|
Hey @kuisathaverat I hope you’re doing well! Could you please take a look at this PR when you have a moment? Getting this fix merged would be a big help for our Jenkins integration, Thank you so much! 🙏 @somiljain2006 thank you for the fix! |
|
Hey @kuisathaverat! I’d like to gently ask again if you could take another look at the PR here. @somiljain2006 Is there any other way I can fix this locally in my configuration? |
Fixes #829
Adds optional support for a Tempo datasource UID (tempoDataSourceUid) to prevent Grafana from dropping the query when rewriting explore URLs. If the UID is not configured, the plugin falls back to the existing tempoDataSourceIdentifier to preserve backward compatibility.
Testing done
Submitter checklist