Fix invalid metric unit strings per OTel UCUM spec#1274
Open
esosaoh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1273.
Replaces
"${description}"unit strings with"{description}"across four monitoring classes. The$prefix is invalid in this context — UCUM annotations use plain curly braces. Other instruments in this codebase (SCMEventMonitoringInitializer, MonitoringCloudListener) already use the correct form.Testing done
String literal changes to metric unit registration. No existing tests assert on instrument unit strings (test suite validates metric names and values, not units). Verified:
./mvnw clean install./mvnw spotless:checkio.jenkins.plugins.opentelemetry.init.JenkinsExecutorMonitoringInitializer indexed under hudson.Extensionio.jenkins.plugins.opentelemetry.init.PluginMonitoringInitializer indexed under hudson.Extensionio.jenkins.plugins.opentelemetry.queue.MonitoringQueueListener indexed under hudson.Extensionio.jenkins.plugins.opentelemetry.security.AuditingSecurityListener indexed under hudson.ExtensionJenkinsOtelPluginIntegrationTestandJenkinsOtelPluginFreestyleIntegrationTestwhich instantiate Jenkins with the plugin loaded, triggering@PostConstructmethods that register these metricsNo new tests added, existing test coverage validates that metrics are registered and emit values correctly. The test suite does not assert on instrument unit strings (only metric names and values), which is appropriate since unit strings are metadata consumed by observability backends, not Jenkins runtime behavior.
Submitter checklist