Add Endpoint URL field to S3Profile

[gmfrasca]

This would allow the ability to override/set the Endpoint URL for an S3Profile (useful for non-Amazon storage systems with S3 interfaces).

To do this currently, it appears you must create a custom endpoints.json to override the defaults, and include it in the actual Jenkins classpath. Allowing the endpoint to be set as a config field should be more a intuitive/maintainable process for this functionality.

[scoheb]

@Jimilian, any chance you can take a look at this please?

[olivergondza]

@Jimilian, @cyrille-leclerc, is there something we can do to get this improvement integrated? Thanks!

[Jimilian]

Hi

Sorry for the huge delay with feedback.

Does this way work for all features? #100 required the file, because it was the recommended way in that time: S3 API recommended it for custom endpoints.

[olivergondza]

@scoheb, can you please follow up with @Jimilian to drive this to completion?

[gmfrasca]

Hello,

I've tested this on AWS and the Ceph's S3 Interface and didn't see any issues (though secondary confirmation would be much appreciated :) ). However, I don't have any other S3 interfaces on hand to run against (such as Swift and Atmos, which are explicitly listed in the README), so I'm not sure if the endpoints file requirement is still necessary there.

You wouldn't have a reference doc for where that requirement came from, would you? Everything I've looked at seems to point to using setEndpoint in-code.

Thanks!

[pecastro]

Hi,

I've stumbled onto this after trying to make the plugin work against Minio based on the notes which have been included in the the README as per #100 .
Currently, assuming one follows the instructions and amends the endpoints.json and overrides the classpath, the plugin will connect and validate against the endpoint in the Jenkins Configuration section but I've been struggling to make it upload anything.
It will always try to resolve the bucket against amazonaws.
I'll give this a shot and report back.

[pecastro]

Yap. This works. 👍

[jineshqa]

@Jimilian @cyrille-leclerc Could you kindly approve this?

[fedepell]

I did some testing using MinIO and it all seems to work fine! (file upload, bucket creation, metadata addition)
Would be definitely great if it could be merged! (Maybe @gmfrasca can just rebase to ease the work up?)

[pere3]

Hello, stumbled upon inability to use this plugin with s3-compatible storage (minio), really glad to see "commented yesterday" here!
+1 for this merge.

[pszubiak]

+1 I have also tested it and it works.

[4n70w4]

Hi! Any news?

[pecastro]

@gmfrasca Any chance you can fix the conflicts so the MR has a better chance of going in ?

[rsandell]

Sorry, I didn't check for existing open PRs when I did #138 I believe this could be made less complex when applied on top of that.

[pecastro]

@rsandell Doesn't this PR become mostly obsolete with #138 ?

[lslebodn]

Sorry, I didn't check for existing open PRs when I did #138 I believe this could be made less complex when applied on top of that.

@gmfrasca Would you mind to rebase and do changes?

[vikulin]

@gmfrasca what would happen if no endpoint was configured, in other words what is an enpoint default value?