Upgrade to use jcasc test harness#49
Merged
Merged
Conversation
jvz
approved these changes
Jan 14, 2020
Member
|
Tagged 1.18.1. Thanks for the PR! |
Member
Author
@jvz what do you think of backporting this to 1.17.x? On the bom we're currently getting (jenkinsci/bom#172): I think it's either backport, or fix the bom PR for 2.190.x and then only having new jcasc versions in the bom on >= 2.190.x which isn't ideal. cc @jglick if you have any other ideas. |
Member
|
If you'd like to backport, please file a PR and I can release from a branch. |
Member
Author
can you create the origin branch that I can PR to please? |
Member
Author
|
One liner: |
Member
|
Branch created! |
Member
Author
|
Backport PR: #50 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JCasc had to create a new dependency that wasn't a
testsclassifier because maven doesn't allow you to bring dependencies through classifiers.Upgrading here so that PCT works again,
Tracking:
jenkinsci/bom#164
Note: We'll need a release for PCT please