Skip to content

feat(java): Require Jenkins core 2.479.1 and Java 17. #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gounthar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(java): Require Jenkins core 2.479.1 and Java 17. #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>3.57</version>
<version>5.7</version>
<relativePath />
</parent>

<properties>
<jenkins.version>2.60.3</jenkins.version>
<java.level>8</java.level>
<!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
<jenkins.baseline>2.479</jenkins.baseline>
<jenkins.version>${jenkins.baseline}.1</jenkins.version>
</properties>

<artifactId>vstestrunner</artifactId>
Expand All @@ -18,36 +20,35 @@
<url>http://wiki.jenkins-ci.org/display/JENKINS/VsTestRunner+Plugin</url>

<scm>
<connection>scm:git:ssh://github.com/jenkinsci/vstestrunner-plugin.git</connection>
<connection>scm:git:https://github.com/jenkinsci/vstestrunner-plugin.git</connection>
<developerConnection>scm:git:ssh://[email protected]/jenkinsci/vstestrunner-plugin.git</developerConnection>
<url>https://github.com/jenkinsci/vstestrunner-plugin.git</url>
<tag>HEAD</tag>
</scm>

<developers>
<developer>
<id>egoughnour</id>
<name>Erik Goughnour</name>
</developer>
<developer>
<id>yasu_s</id>
<name>Yasuyuki Saito</name>
</developer>
</developers>

<licenses>
<license>
<name>The MIT license</name>
<url>http://www.opensource.org/licenses/mit-license.php</url>
<distribution>repo</distribution>
</license>
</licenses>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-${jenkins.baseline}.x</artifactId>
<version>4136.vca_c3202a_7fd1</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>

<dependencies>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>structs</artifactId>
<version>1.17</version>
</dependency>
</dependencies>

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/jenkinsci/plugins/vstest_runner/VsTestInstallation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import jenkins.model.Jenkins;
import net.sf.json.JSONObject;
import org.kohsuke.stapler.DataBoundConstructor;
import org.kohsuke.stapler.StaplerRequest;
import org.kohsuke.stapler.StaplerRequest2;

import java.io.File;
import java.io.IOException;
Expand Down Expand Up @@ -129,7 +129,7 @@ public String getDisplayName() {
}

@Override
public boolean configure(StaplerRequest req, JSONObject json) {
public boolean configure(StaplerRequest2 req, JSONObject json) {
setInstallations(req.bindJSONToList(VsTestInstallation.class, json.get("tool"))
.toArray((VsTestInstallation[]) Array.newInstance(VsTestInstallation.class, 0)));
save();
Expand Down