re-assign window[window['JS-Widget']]#1
Open
nalbion wants to merge 1 commit into
Open
Conversation
I don't understand why you reassign `globalObject` but not `window[window['JS-Widget']]`. Also, `supportedAPI` seems redundant, line 46 could be moved to replace the default handler at line 56.
Owner
You are right. The thing is that this is just basic example - in real widget you will probably want to store configurations in separate service and expose API via some other service.
You are right here as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't understand why you reassign
globalObjectbut notwindow[window['JS-Widget']].Also,
supportedAPIseems redundant, line 46 could be moved to replace the default handler at line 56.