Use ignore directive to ignore test files not to be passes to gofumpt #4936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have adopted the workaround passing a result of `git ls-files '*.go' ':!vendor'` to gofumpt in jesseduffield#4809. Currently, gofumpt suports `ignore` directive. So we can use it without any workarounds.
After [v0.9.0](https://github.com/mvdan/gofumpt/releases/tag/v0.9.0), gofumpt prohibits "naked return" for the sake of clarity. This makes more readable when "named return value" is used. For more infomation for "prohibition of naked return": mvdan/gofumpt#285.
By running [email protected], the return value of `makeAtomic` function is specified. After that, golangci-lint shows an error like `return copies lock value: sync/atomic.Int32 contains sync/atomic.noCopy`. This happens because atomic values should not be copied. So I made a change using them as pointers.
gofumpt version for local developement is updated to `v0.9.1`. This commit updates golangci-lint to `v2.5.0` which is the lastest and the first version supports `[email protected]` to match the behavior of local dev and ci. This version of golangci-lint supports go 1.24 as well.
kyu08
commented
Oct 5, 2025
| in, err := os.Open(src) | ||
| if err != nil { | ||
| return //nolint: nakedret | ||
| return err |
There was a problem hiding this comment.
This commit does not change actual behavior of this functions because err is returned originally because this function uses "named return value".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To replace the workaround introduced in #4809 with
ignoredirective to make the code simpler.Overview
This is a follow-up PR to #4809.
I have added 4 changes due to updating gofumpt to remove
git ls-filesworkaround.Please take a look at each commit messages for details.
Please check if the PR fulfills these requirements
go generate ./...)