Don't extend until constructor #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to use require to include this without getting an error that `google` is not defined if it beats the Maps API to load (say you're loading it asynchronously or via https://www.npmjs.com/package/google-maps). It won't extend until the constructor.
|
Excellent addition! Thanks @ethanclevenger91. |
|
Published in |
jesstelford
pushed a commit
that referenced
this pull request
May 23, 2016
jesstelford
pushed a commit
that referenced
this pull request
May 24, 2016
jesstelford
pushed a commit
that referenced
this pull request
May 24, 2016
Closed
|
I had roll this back due to #9. I've published a fix in |
|
Ho jeez sorry about that. Yeah, definitely okay with rolling back.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to use require to include this without getting an error that
googleis not defined if it beats the Maps API to load (say you're loading it asynchronously or via https://www.npmjs.com/package/google-maps). It won't extend until the constructor.