chore(expect): expose default matchers - #11932
Conversation
a1c49e3 to
c358324
Compare
Codecov Report
@@ Coverage Diff @@
## main #11932 +/- ##
==========================================
- Coverage 68.75% 68.74% -0.01%
==========================================
Files 322 322
Lines 16587 16587
Branches 4787 4787
==========================================
- Hits 11404 11403 -1
- Misses 5151 5152 +1
Partials 32 32
Continue to review full report at Codecov.
|
|
We can do this for now, but I'll probably remove it from Jest 28 (in favour of a more explicit import (somehow)). Is this one change enough for you in playwright? |
|
Also, can you rebase? Just to trigger GH actions which was down when you opened this (https://www.githubstatus.com/incidents/bdbzpz7qxmbx) |
c358324 to
c25e267
Compare
Yes looks good from our side. We then only mirror Thanks Simen. 👍 |
just to maybe trigger ci
|
Lint is still unhappy. I'm on mobile, otherwise I'd fix it 🙂 |
f410d39 to
cd8ffe4
Compare
|
Its fixed now, thanks! |
|
Thanks Simen, works! do you think its also possible to merge #11498? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Projects which use expect sometimes want to have access to the default matchers before they get overridden. This was not possible before and lead to
ERR_PACKAGE_PATH_NOT_EXPORTED. After this change it's possible to require it viaexpect/build/matchers.Context: