Improve consistency in API of FormFields maxFields and maxLength #12718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
…letContextHandler Signed-off-by: Lachlan Roberts <[email protected]>
…ContextHandler Signed-off-by: Lachlan Roberts <[email protected]>
gregw
requested changes
Jan 24, 2025
Signed-off-by: Lachlan Roberts <[email protected]>
|
@lachlan-roberts I've restarted CI to see if the new failures are flakes or related. |
gregw
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like the usage of
-1for a defaultmaxFieldsandmaxLengthvalue as we already have methods which don't take thesemaxFieldsandmaxLengthparameters which will give you a default value anyway.But if we decide to use
-1for a default value we should make it consistent across the other non-deprecated methods.Methods like
CompletableFuture<Fields> from(Request request, Charset charset, int maxFields, int maxLength)are still using -1 for unlimited, but these are deprecated.