Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jetty-http-spi] add filter support #12764

Merged
merged 3 commits into from
Feb 12, 2025
Merged

[jetty-http-spi] add filter support #12764

merged 3 commits into from
Feb 12, 2025
+54 −1

Conversation

SentryMan
Copy link
Contributor

Now calls filters before executing the HTTP handler

Fixes #9125

@olamy
Copy link
Member

olamy commented Feb 11, 2025

Thanks for the contribution.
Could you please add a junit test for this?
Thanks

@olamy olamy self-assigned this Feb 11, 2025
olamy
olamy approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregw gregw merged commit 44c2971 into jetty:jetty-12.0.x Feb 12, 2025
9 checks passed
@SentryMan SentryMan deleted the spi-filter branch February 12, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

Assignees

@olamy olamy

Labels
None yet
Projects
Jetty 12.0.18
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jetty-http-spi: Filters in HttpContext/JettyHttpContext ignored, implementation missing
3 participants
@SentryMan @olamy @gregw