Introduce Scanner.ChangeSetListener #12769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Update testing for all Listeners
sbordet
requested changes
Feb 9, 2025
There was a problem hiding this comment.
There is a chance to cleanup this class, in particular by consolidating the "warn" logs.
They should be INFO or DEBUG level, not WARN, since we just log and ignore the failure, and the Scanner continues to operate as nothing happened.
Furthermore, remove the Scanner.warn() method, since in the rest of the class LOG.warn() is used instead.
I would prefer to see LOG.info()/debug() everywhere.
interface Listener should extend java.util.EventListener.
| //Call the BulkListeners | ||
|
|
||
| // Call the ChangeSetListeners | ||
| reportChangeSet(changes); |
There was a problem hiding this comment.
I would report the changes before the DiscreteListeners.
Is there a reason the changes are notified in between what was notified before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small subset of the changes from PR #12583 made as a new PR just so we can track these changes separately from the deploy changes.