fix(dashboard): format Potential savings stat with configured currency - #215
fix(dashboard): format Potential savings stat with configured currency#215SomSamantray wants to merge 3 commits into
Conversation
Closes jez500#196 - the Potential savings stat hardcoded a dollar sign instead of using the configured default currency and locale.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe dashboard Potential Savings stat now uses ChangesPotential Savings currency formatting
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Babysit run reportAutomated watch of this PR (pipeline mode) stopped with one residual:
State at stop: no unresolved review threads, no other actionable feedback. CodeRabbit's own review was still in progress on the current head and will report separately. Once the run is approved, re-run |
The dashboard "Potential savings" stat now renders in the configured default currency and locale instead of a hardcoded dollar sign. A user on EUR/GBP/AUD previously saw a
$value that did not match the rest of their dashboard; the stat now uses the sameCurrencyHelperformatting as the min/avg/max aggregates and product cards.Fixes #196
Tests: new
tests/Feature/View/StatBarTest.phpcovers configured-currency (EUR) and USD rendering of the stat cell. The full suite runs in CI (php artisan test); a local run was not possible in this environment (no PHP/Docker), so CI is the verification run.Summary by CodeRabbit
Bug Fixes
Tests
Documentation