-
Notifications
You must be signed in to change notification settings - Fork 5
[WIP] Support elm 0.19 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
All tests are now passing except those related to custom |
Published We also need to enable Travis tests for PRs in this repo. The ones in my fork pass: https://travis-ci.com/kachkaev/run-elm/builds/85100237. |
@jfairbank if you have a second, could you please go to https://travis-ci.org/jfairbank/run-elm/settings and enable Build pushed pull requests like this? |
@kachkaev It's already enabled. GitHub services are deprecated, so I removed the Travis service and reinstalled it as a GitHub app. Maybe that will fix the problem? Try force pushing or something to trigger a build. |
Hmm it did not trigger... |
what can we do here? |
@brandly I got the fork working here a while ago: Haven't looked at it for a while, so feel free to enhance it if needed. |
thanks for the quick reply! i'm interested in CLIs written in elm, and it looked like |
does the fork not support |
we have 0.19.1 meanwhile, any news here? |
This PR is a heads-up to my attempt to support Elm 0.19. The upgrade involves quite a lot of change from the way we execute
node-elm-compiler
to what we keep in fixtures.Most of the tests pass, there are only one that needs some more work is
path-to-elm
. I'm temporary skipping it. Hope I'll find time to better document changes as well.