Update helloworld to load pages correctly in FreePBX 17 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix spelling of licence to license in module.xml (otherwise error in /var/www/html/admin/libraries/BMO/GuiHooks.class.php line 250)
Added isset($_REQUEST['view']) to /var/www/html/admin/modules/helloworld/Helloworld.class.php line 279
Add isset to check for $id, $subject and $body as well as pull up </textarea> to stop adding default space
|
As another note, either the notes aren't saving, or they aren't being loaded from the DB correctly. I didn't need to work off that functionality so I didn't continue debugging that issue. If I end up doing that I'll one day make another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three files leading to errors after a fresh install of the helloworld module.
Gist of the update is fixing misspelling in XML file and adding issets where they were missing.