Skip to content

added nix package manager support#378

Open
reshmifrog wants to merge 2 commits into
mainfrom
RTECO-1040-Nix-package-support
Open

added nix package manager support#378
reshmifrog wants to merge 2 commits into
mainfrom
RTECO-1040-Nix-package-support

Conversation

@reshmifrog
Copy link
Copy Markdown
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Appropriate label is added to the PR for auto generate release notes.

Added the support for nix package manager

@reshmifrog reshmifrog added feature request New feature or request new feature Automatically generated release notes and removed feature request New feature or request labels May 7, 2026
Copy link
Copy Markdown

@Balasubramanyamkosuri Balasubramanyamkosuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Thanks for the Nix flexpack work — the flexpack/nix/ package and unit tests look solid.

Blocker: mergeArtifacts regression

This PR removes logic in entities/buildinfo.go that prefers a non-. artifact path when SHA1 matches:

if existingArtifact.Path == "." && newArtifact.Path != "." {
    (*intoArtifacts)[i] = newArtifact
}

That path preference is required for native UV/Poetry publish flows: artifacts are first recorded locally (path="."), then merged again after Artifactory upload with the real repo path. Without it, publish build-info can keep stale local paths and break property stamping / artifact browser links.

Please revert that hunk or add regression tests (UV publish ITs in jfrog-cli cover this).

Questions

  1. bi nix uses hard-coded CollectBuildInfo("nix-build", "1") — is that intentional for a follow-up?
  2. Confirm PR targets the correct base branch per repo policy.

Full structured review: see team doc docs/reviews/nix-pr-review.md in the Nix workspace.

Comment thread flexpack/nix/narinfo_parser.go
Comment thread flexpack/nix/nix_channel_collector.go
Comment thread flexpack/nix/nix_types.go
Comment thread flexpack/nix/narinfo_parser.go
Comment thread flexpack/nix/narinfo_parser.go
Comment thread cli/cli.go
Comment thread cli/cli.go
Comment thread entities/buildinfo.go
Comment thread flexpack/nix/nix_channel_collector.go
Comment thread entities/buildinfo.go
Comment thread flexpack/nix/narinfo_parser.go
Comment thread flexpack/nix/narinfo_parser.go
Comment thread flexpack/nix/nix_channel_collector.go
Comment thread flexpack/nix/nix_channel_collector.go
Comment thread flexpack/nix/nix_channel_collector.go
Comment thread flexpack/nix/nix_types.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants