added nix package manager support#378
Open
reshmifrog wants to merge 2 commits into
Open
Conversation
Balasubramanyamkosuri
left a comment
There was a problem hiding this comment.
Review summary
Thanks for the Nix flexpack work — the flexpack/nix/ package and unit tests look solid.
Blocker: mergeArtifacts regression
This PR removes logic in entities/buildinfo.go that prefers a non-. artifact path when SHA1 matches:
if existingArtifact.Path == "." && newArtifact.Path != "." {
(*intoArtifacts)[i] = newArtifact
}That path preference is required for native UV/Poetry publish flows: artifacts are first recorded locally (path="."), then merged again after Artifactory upload with the real repo path. Without it, publish build-info can keep stale local paths and break property stamping / artifact browser links.
Please revert that hunk or add regression tests (UV publish ITs in jfrog-cli cover this).
Questions
bi nixuses hard-codedCollectBuildInfo("nix-build", "1")— is that intentional for a follow-up?- Confirm PR targets the correct base branch per repo policy.
Full structured review: see team doc docs/reviews/nix-pr-review.md in the Nix workspace.
naveenku-jfrog
requested changes
May 19, 2026
agrasth
reviewed
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the support for nix package manager