Skip to content

Adding support for bitbucket cloud#1298

Merged
eranturgeman merged 9 commits intojfrog:v3_erfrom
eranturgeman:add-support-for-bitbucket-cloud
May 7, 2026
Merged

Adding support for bitbucket cloud#1298
eranturgeman merged 9 commits intojfrog:v3_erfrom
eranturgeman:add-support-for-bitbucket-cloud

Conversation

@eranturgeman
Copy link
Copy Markdown
Collaborator

@eranturgeman eranturgeman commented May 4, 2026 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Add support for Bitbucket cloud, depends on jfrog/froggit-go#191

Important notes:

  1. We currently does not support using API tokens + username, only Repository/Project/Workspace tokens that are be provided through JF_GIT_TOKEN
  2. Don’t need to provide JF_BB_GIT_USER

@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels May 4, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label May 4, 2026
@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes and removed improvement Automatically generated release notes labels May 5, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label May 5, 2026
@eranturgeman
reversing comments order in scan-pr for BB cloud as they present comm…
921dee2 
…ents latest at the top and not chronological
@eranturgeman eranturgeman requested review from omerzi and orto17 and removed request for orto17 May 5, 2026 15:57
@eranturgeman eranturgeman requested review from attiasas and orto17 May 5, 2026 15:57
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label May 5, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label May 5, 2026
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label May 6, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label May 6, 2026
attiasas
attiasas reviewed May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@attiasas attiasas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! take a look at my comments
Also check out: (see if still needed)

Comment thread utils/getconfiguration.go Outdated
Comment thread scanrepository/scanrepository.go Outdated
Comment thread utils/git.go Outdated
Comment thread utils/comment.go
@eranturgeman eranturgeman mentioned this pull request May 7, 2026
Closed
13 tasks
attiasas
attiasas approved these changes May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label May 7, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

👍 Frogbot scanned this pull request and did not find any new security issues.

@eranturgeman eranturgeman merged commit c6f07fa into jfrog:v3_er May 7, 2026
22 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@attiasas attiasas attiasas approved these changes

@orto17 orto17 Awaiting requested review from orto17

Assignees

No one assigned

Labels

new feature Automatically generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eranturgeman @attiasas