Fix V3 action and improve OIDC error recognition#1332
Merged
eranturgeman merged 3 commits intoMay 28, 2026
Merged
Conversation
eranturgeman
force-pushed
the
fix-v3-action-and-oidc-error-recognition
branch
from
eb996bc to
1d61a09
Compare
eranturgeman
force-pushed
the
fix-v3-action-and-oidc-error-recognition
branch
from
1d61a09 to
a0a28c1
Compare
eranturgeman
added
bug
github-actions
Bot
removed
the
safe to test
action/src/utils.ts + action/lib/utils.js: - Check HTTP status code before parsing response; @actions/http-client never throws on 4xx/5xx so failures were previously silent - Handle OAuth2 error format (error/error_description) in addition to JFrog format (errors array) - Set JF_ACCESS_TOKEN only after validating access_token is present; previously undefined coerced to the string "undefined", causing frogbot to run with Authorization: Bearer undefined .github/workflows/oidc-test.yml: - Remove username from identity mapping token_spec; the referenced user did not exist on the test server, causing all token exchanges to fail action/test/main.spec.ts: - Add explicit string type annotations (ESLint typedef rule) - Fix afterEach cleanup: delete JF_PASSWORD not PASSWORD .gitignore + action/.husky/pre-commit: - Add /action/node_modules/ to gitignore to hide devDep untracked files - Force-add and restore devDeps after prune so IDE stays working
eranturgeman
force-pushed
the
fix-v3-action-and-oidc-error-recognition
branch
from
3253e59 to
d0b4047
Compare
eranturgeman
added
the
safe to test
github-actions
Bot
removed
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the OIDC mechanism error detection and fix some issues regarding incorrect env vars + fixes the test by removing redundant claim from the id-mapping generation
In addition if fixes a local dev issue where when working on action files all node_modules including devDependencies are being pushed
Tests are validated to pass in a fork