Skip to content

Log audit errors when partial results are allowed (v2 backport)#1354

Merged
Jordanh1996 merged 1 commit into
jfrog:devfrom
Jordanh1996:fix/log-scanner-errors-when-partial-results-v2
Jun 17, 2026
Merged

Log audit errors when partial results are allowed (v2 backport)#1354
Jordanh1996 merged 1 commit into
jfrog:devfrom
Jordanh1996:fix/log-scanner-errors-when-partial-results-v2

Conversation

@Jordanh1996

Copy link
Copy Markdown

Summary

  • Backport of Log audit errors when fail_upon_any_scanner_error is disabled #1352 to master (v2)
  • When partial results are allowed (allow_partial_results / FailUponAnyScannerError disabled), include the underlying scanner error in the warn log instead of only a generic message
  • Avoid double-logging fix errors by not embedding err in the message at the fix-vulnerabilities call site

Test plan

  • Run scan-repository with partial results allowed and a failing audit; confirm the warn line includes the scanner error text and exit code stays 0
  • Run with partial results disabled; confirm behavior is unchanged (command fails on scanner error)

Made with Cursor

@attiasas attiasas changed the base branch from master to dev June 17, 2026 08:46
@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jun 17, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Jun 17, 2026

@attiasas attiasas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

When allow_partial_results is enabled, frogbot continued without failing
but only logged a generic warning, hiding the underlying audit error.
Include the actual error in the warning so pipelines remain debuggable.

Backport of jfrog#1352 for master.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Jordanh1996 Jordanh1996 force-pushed the fix/log-scanner-errors-when-partial-results-v2 branch from b5ae00e to 31feeb3 Compare June 17, 2026 08:47
@Jordanh1996 Jordanh1996 merged commit ec03767 into jfrog:dev Jun 17, 2026
5 of 6 checks passed
@Jordanh1996 Jordanh1996 deleted the fix/log-scanner-errors-when-partial-results-v2 branch June 17, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants