Skip to content

pnpm update error output handling#465

Merged
reshmifrog merged 7 commits into
jfrog:mainfrom
Phavya-jfrog:fix/pnpm-install-error-output
Jun 10, 2026
Merged

pnpm update error output handling#465
reshmifrog merged 7 commits into
jfrog:mainfrom
Phavya-jfrog:fix/pnpm-install-error-output

Conversation

@Phavya-jfrog

@Phavya-jfrog Phavya-jfrog commented May 29, 2026

Copy link
Copy Markdown
Contributor
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • Appropriate label is added to auto generate release notes.
  • I used gofmt for formatting the code before submitting the pull request.
  • PR description is clear and concise, and it includes the proposed solution/fix.

pnpm install failures previously returned a generic error with no pnpm output in the returned error, making failures hard to diagnose.

This PR tees stdout/stderr in runPnpmInstall() and appends the captured output to the error on failure, while still streaming output live to the terminal.

@reshmifrog

Copy link
Copy Markdown
Contributor

@Phavya-jfrog please add required labels

@Phavya-jfrog

Copy link
Copy Markdown
Contributor Author

@Phavya-jfrog please add required labels

I dont have access to add labels

@reshmifrog reshmifrog added the improvement Automatically generated release notes label Jun 10, 2026
Comment thread artifactory/commands/pnpm/install.go
reshmifrog
reshmifrog previously approved these changes Jun 10, 2026
naveenku-jfrog
naveenku-jfrog previously approved these changes Jun 10, 2026
@fluxxBot fluxxBot self-requested a review June 10, 2026 07:49
@reshmifrog reshmifrog merged commit 82ce7d9 into jfrog:main Jun 10, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants