Conversation
attiasas
requested changes
Apr 9, 2026
Collaborator
There was a problem hiding this comment.
We already have:
DepType: components.NewStringFlag(DepType, "[npm] Defines npm dependencies type. Possible values are: all, devOnly and prodOnly."),
func (abp *AuditBasicParams) SetNpmScope(depType string) *AuditBasicParams {
switch depType {
case "devOnly":
abp.args = []string{"--dev"}
case "prodOnly":
abp.args = []string{"--prod"}
}
return abp
}
Why not extend that?
Contributor
Author
Implemented |
attiasas
requested changes
Apr 15, 2026
Collaborator
attiasas
left a comment
There was a problem hiding this comment.
If we use DepType Why do we also need the flag LegacyPeerDeps?
Why not adding DepType to CurationAudit and use it? (i.e support DepType in Curation Audit)
--legacy-peer-deps --> --dep-type=legacyPeerDeps
11a31b8 to
8b1ffd0
Compare
attiasas
requested changes
Apr 28, 2026
Collaborator
attiasas
left a comment
There was a problem hiding this comment.
Please check my comments.
In addition consider adding test cases for new options
5a664f5 to
090e4b7
Compare
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
267ce1e to
c2ba8cb
Compare
7b527a6 to
c14b8a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

devbranch.go vet ./....go fmt ./....Added support for --legacy-peer-deps Done
Benefits :- It unblocks curation auditing for npm projects that can't install cleanly under npm 7+, which is a very common real-world situation — many projects maintain older dependencies or have transitive peer conflicts they haven't resolved. Without this flag, those projects would simply be unable to run jf ca at all.
--run-native flag for jf ca (Curation Audit)
Problem it solves
jf ca normally injects Artifactory as the npm registry during dependency resolution (writes .npmrc, runs npm install). This breaks for users who:
What --run-native does
When passed, jf ca hands off dependency resolution entirely to the user's native npm environment:
Constraints
npm registry in .npmrc must be an Artifactory npm registry (URL must contain /api/npm/)
Supports both standard (/artifactory/api/npm/) and reverse-proxy URLs (where /artifactory context root is stripped)
If the registry is not Artifactory, the command fails with a clear error
Error handling
If authentication fails (401), the audit stops immediately with a descriptive error pointing the user to run jf c to fix their server configuration — no misleading "0 blocked packages" result is shown