Add root dir to determine paths for sast changed files#743
Merged
Add root dir to determine paths for sast changed files#743
Conversation
meirjfrog
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fix(audit/sast): use root dir for SAST changed-file pathsSummary
SAST “changed files” resolution now keys off the audit root directory (the CLI root when set) instead of only the scan targets’ common parent.
AuditParamscarries that root, andSastChangedFilesForTargettakes arootDirand builds absolute paths under it. Path handling is simplified by dropping extra normalization of git paths before joining to the root.Changes
commands/audit/auditparams.go: AddrootDironAuditParamswithSetRootDir/RootDir.commands/audit/audit.go: CallSetRootDir(auditCmd.rootDir)when building audit params; introducegetRootDirto use an explicit root when non-empty, otherwisescanResults.GetCommonParentPath(); pass that intoSastChangedFilesForTarget.jas/sast/sastscanner.go: Rename the last parameter conceptually from common parent torootDir; compute target-relative paths vsrootDir; simplifycollectSastChangedAbsPaths(joincommonAbs+ changed path directly; removenormalizeRepoRelativeChangedPath).jas/sast/sastscanner_test.go: UpdateTestSastChangedFilesForTargetforrootDirand adjust the absolute-path case to a repo-relative changed file.