Feature/xray 138688 add pnpm support for jf ca#769
Open
gauriy-tech wants to merge 4 commits into
Open
Conversation
… and improved install logging - Reject pnpm versions below 10.x with a clear error message - Refresh pnpm-lock.yaml when package.json is newer (stale lockfile) - Log full install command including --lockfile-only and --ignore-scripts flags - Add unit tests for validatePnpmMinVersion Co-authored-by: Cursor <cursoragent@cursor.com>
…-native warning - Enforce pnpm 10.x only (reject <10 and >10); add maxPnpmMajorVersion=10 const - Align version rejection message with yarn's wording pattern - Fix test: v11 correctly expected to be rejected - Warn via log.Warn when --run-native is passed for pnpm (no-op, always native) Co-authored-by: Cursor <cursoragent@cursor.com>
69b4e25 to
2e42139
Compare
2e42139 to
57e880a
Compare
57e880a to
1dbd2fb
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
1dbd2fb to
8bee66c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....What: Added pnpm support to jf ca (curation audit) using lockfile-based dependency resolution
Why: jf ca can't run pnpm ls (requires node_modules) — lockfile parsing avoids any tarball downloads
How: pnpm install --lockfile-only generates/refreshes the lockfile, then pnpm-lock.yaml is parsed directly. jf audit/jf scan pnpm workflow is unchanged.
Scope: Only pnpm v10.x supported. jf audit path untouched.
Test plan: new unit tests in pnpm_test.go, pnpmlock_test.go, curationaudit_test.go
Detailed Test execution plan is here https://jfrog-int.atlassian.net/browse/XRAY-144540