XRAY-144809 - CA command [Maven]: Add option to consider plugin deps#771
Conversation
cda523a to
61a0c42
Compare
61a0c42 to
93373e9
Compare
93373e9 to
086f4ce
Compare
086f4ce to
5e9df69
Compare
5e9df69 to
1eaaa16
Compare
|
I have read the CLA Document and I hereby sign the CLA |
attiasas
left a comment
There was a problem hiding this comment.
Nice job!
Please add an integration test case with a project replicating that.
I would consider also adding this option to jf audit command. most of the logic is the same, users may want to include this in their scan as well
|
Also, why this is not implemented in |
|
This is needed by a customer, we have consider it to take as a long term solution in https://github.com/jfrog/maven-dep-tree in upcoming quarter |
|
Keeping it for curation scope for this PR , will connect with audit team to discuss enabling for their workflow |
1eaaa16 to
11f8efd
Compare
|
Added an integration test case maven tree - one blocked plugin dependency in TestDoCurationAudit (commands/curation/curationaudit_test.go), with a new fixture under tests/testdata/projects/package-managers/maven/maven-curation-plugin-deps/. What it tests (real mvn run against the mock curation server): jf ca --mvn-include-plugin-deps detects a curation-blocked artifact that only enters the build via a Maven build plugin's transitive closure — the exact "0 blocked in jf ca but build is blocked" scenario. |
…include-mvn-plugins # Conflicts: # commands/curation/curationaudit.go # sca/bom/buildinfo/technologies/common.go
Should be documented that this is a "temp" fix. I whould rather you add it to the actual maven-dep-tree repo and we will add this only if its urgent until actually implemented. should be documented and tracked |
|
This is needed by a customer, we have consider it to take as a long term solution in https://github.com/jfrog/maven-dep-tree in upcoming quarter - https://jfrog-int.atlassian.net/browse/XRAY-145307 |
attiasas
left a comment
There was a problem hiding this comment.
LGTM for now. pending to see logic moved to maven-dep-tree
devbranch.go vet ./....go fmt ./....Full details about the RCA and Fix is described here https://jfrog-int.atlassian.net/browse/XRAY-144809?focusedCommentId=1115010
After Fix


Before Fix
