Move package updaters from Frogbot into jfrog-cli-security#775
Open
orto17 wants to merge 8 commits into
Open
Conversation
Relocates the package updater implementations (Go, Maven, Npm, Pnpm, Pip/Poetry/Pipenv) from the Frogbot repository into utils/remediation/packageupdaters/ so they can be shared by both Frogbot and the auto-fix action. Introduces a lean FixDetails struct and a GetCompatiblePackageUpdater factory. Removes unsupported technologies (Yarn, Gradle, Nuget, Conan). Moves test files and testdata alongside the implementation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add techutils.Poetry and techutils.Pipenv to GetCompatiblePackageUpdater (both route to PythonPackageUpdater, which already handles them internally) - Add them to SupportedFixTechnologies for consistency - Add TestGetCompatiblePackageUpdater covering all supported and unsupported techs - Run go mod tidy to promote gjson/sjson from indirect to direct requires Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
orto17
added
the
safe to test
github-actions
Bot
removed
the
safe to test
Jordanh1996
reviewed
Jun 14, 2026
| } | ||
| } | ||
|
|
||
| func TestGetAllDescriptorFilesFullPaths(t *testing.T) { |
There was a problem hiding this comment.
I notice that it fails in the unit tests?
4 tasks
attiasas
requested changes
Jun 15, 2026
attiasas
left a comment
attiasas
left a comment
Collaborator
There was a problem hiding this comment.
Nice job, I would just move some of the files to different location for this repository
testdatashould be undertests/testdata, prefer to use currently avaliable projects if you can. add if missing under the right location- I would put
utils/remediationinsca/remediationor evenremediation/scafrom root (in case we will expend to remediate JAS as well)
attiasas
added
ignore for release
github-actions
Bot
removed
the
safe to test
- utils/remediation/packageupdaters/ -> remediation/sca/packageupdaters/ - utils/remediation/testdata/ -> tests/testdata/projects/remediation/ - Update testdata relative paths in test files - Fix TestGetAllDescriptorFilesFullPaths expected results to include multi1/pom.xml
orto17
added
the
safe to test
github-actions
Bot
removed
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relocates the package updater implementations (Go, Maven, Npm, Pnpm, Pip/Poetry/Pipenv) from the Frogbot repository into utils/remediation/packageupdaters/ so they can be shared by both Frogbot and the auto-fix action. Introduces a lean FixDetails struct and a GetCompatiblePackageUpdater factory. Removes unsupported technologies (Yarn, Gradle, Nuget, Conan). Moves test files and testdata alongside the implementation.
devbranch.go vet ./....go fmt ./....