-
Notifications
You must be signed in to change notification settings - Fork 11
Include submodules in CI build #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update NuGet icon link in README_Feature.md
I don't really understand why this would be necessary? This is not using any submodules? So I don't see why this is needed? Builds on this repo have been running fine without it? |
Yes, sorry for not being clear. I just bumped to that problem when tried to build a solution that consist submodules and thought it would be good to share solution with others and make the pipelines more resilient. But now it turned out that even more is needed to be changed when building NuGet that uses submodules, so this PR should be further updated. However I totally understand if you don't want to over-complicate this template, so no hard feelings if you just drop my PR :) |
Just to give a glimpse what are we dealing with I have updated the PR with things that need to be done in order to create a NuGet when using submodules. As I wrote before, I totally understand if you decide not to pull this up as it might reduce readability of your template. And just to make story complete - I developed this solution because I wanted to incorporate Plugin.Maui.Audio with silence detection (which is still waiting for merge) into Plugin.Maui.Chat. Maybe I am missing something and there was a simpler way to do it? |
Hm yeah I appreciate the effort and adding this! I don't think this will be something a lot of people will run into? Can we maybe instead somehow add this as documentation maybe to the wiki or readme? What do you think? |
Maybe putting code in separate branch and adding an annotation about submodules branch in readme? |
It is necessary to explicitly declare using submodels in solution. Otherwise builder goes with the error MSB3202: The project file was not found.