Update peer dependencies #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue with the peer dependencies where and older version of leaflet would be installed on top of my applications leaflet dependency causing a mismatch between the marker file div-icon loaded and the leaflet version.
node_modulesbut react-leaflet-div-icon will also get leaflet 0.x.x in it's dependenciesmarkermodule in leaflet, it first looks its local node_modules for leaflet, which it finds and then I get an error because of module mismatchI've updated the peer dependencies to specify the 1.x.x versions which I think should be fine because it looks like you've included updates recently to support react-leaflet's newer api and therefore the module is probably not compatible with older versions of leaflet/react-leaflet anyway