Fixed issue with redundant mounting/unmounting + better position check #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Since the ContextProvider component was created in the renderComponent function, it caused react to mount and unmount the component on every render, since renderComponent created a new ContextProvider class every time. We had a marker with an image in it, and we could see the image reload on every render. If you put a componentDidMount in your inner component you can see it being raised on every render.
We have moved the creating of the ContextProvider to the componentDidMount, as there is no real reason to create it every time, specifically since context is added statically and doesn't change in runtime.
We also we have changed the comparison of the position, since if you use the component like:
It will cause the setLatLng function to be called even if nothing changed, since the comparison was done by array reference.