Open
Conversation
Author
|
I'm hoping to get this merged, so I can remove my fork and use the gem directly. I think this will help others on ruby 1.9.3. Please let me know if there are any concerns, and hopefully I can address them. :-) |
Author
|
Update on this, we've had it in QA for about ~2 months and it's been performing well. We are headed to production with this change. Getting this merged is still a cleanup task, and I just wanted to confirm the patch is doing well. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had an issue on ruby 1.9.3
strip!': can't modify frozen String (RuntimeError)This happens because the version number passed in is frozen and the downstream code mutates it, causing an exception.