Skip to content
This repository was archived by the owner on May 15, 2018. It is now read-only.

Conversation

jgraham
Copy link
Owner

@jgraham jgraham commented Dec 19, 2017

r? @andreastt


This change is Reviewable

This mirrors the API of std::process::Command, and provides more
flexible access to the handles for stdout and stderr than the previous
iteration of the API.
The profile has to be kept alive over the lifetime of the process.
Repository owner deleted a comment from vijoyp Jan 10, 2018
Copy link
Contributor

@andreastt andreastt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you have addressed my original concerns here.

I do agree with your assessment that we should land this in m-c so we can be a bit more confident it actually works, however.

@jgraham Are you happy if I go ahead and put the master branch of this repo in central as it is, then you resubmit this as a patch there? I think that will get us the best sort of test coverage.

@jgraham
Copy link
Owner Author

jgraham commented Jan 10, 2018

Sure

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants