fix: opacity property's @update decorator was never renamed to @mark_changed - #40
Merged
Merged
Conversation
…changed main is currently broken -- `import spatialgeometry` raises NameError: name 'update' is not defined. jhavl#34 (opacity property) and jhavl#38 (renamed the @update decorator to @mark_changed, since it collided with the new public SceneNode.update() method) were both branched independently before either merged, so neither PR's diff touched the other's code. jhavl#38 merged first, then jhavl#34's own new opacity setter -- still using the pre-rename @update -- merged cleanly on top with no conflict, silently reintroducing a decorator name that no longer exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainis currently broken --import spatialgeometryraisesNameError: name 'update' is not defined.#34 (opacity property) and #38 (renamed the
@updatedecorator to@mark_changed, since it collided with the new publicSceneNode.update()method) were both branched independently before either merged, so neither
PR's diff touched the other's code. #38 merged first; then #34's own new
opacitysetter -- still using the pre-rename@update-- merged cleanlyon top with no conflict, silently reintroducing a decorator name that no
longer exists.
Test plan
import spatialgeometry-- confirmedNameErrorbefore this fix,confirmed clean after
pytest tests/-- 167 passed