Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Live logs, View Full Log & Download Log in single instance/master behind LB. #228

Closed
wants to merge 3 commits into from
Closed

Conversation

BitProcessor
Copy link

Uses an extra entry in the client object in config.json:

	"client": {
		"custom_live_log_socket_url": "https://example.com",

@jhuckaby
Copy link
Owner

Thanks for this! But unfortunately, you (probably inadvertently) changed all the spacing in the file, rendering the diff virtually unreadable:

https://github.com/jhuckaby/Cronicle/pull/228/files

I can't see where the actual changes are, because there are so many whitespace changes. This is probably just something weird going on with your text editor. Don't worry tho, I'll try to locate the specific non-whitespace changes you made, and just manually apply them to the master branch.

Thanks for your work on this!

@jhuckaby
Copy link
Owner

Change applied in 55c6489

Thanks again!

@jhuckaby jhuckaby closed this Oct 17, 2019
@BitProcessor
Copy link
Author

BitProcessor commented Oct 17, 2019

I think it automatically replaces all tabs with a number of spaces. Seems you have found the changes though. If you want to double check: they all had a comment with ‘BitProcessor’ in them. Thanks for merging! :-D

@lukasmrtvy
Copy link

@BitProcessor it should fix #123, right ?

@BitProcessor
Copy link
Author

@BitProcessor it should fix #123, right ?

If it's a single master setup => yes

@lukasmrtvy
Copy link

@BitProcessor

it should work as environment variable out of the box, isnt it ?
I am using:

  • CRONICLE_base_app_url='https://cronicle.example.com'
  • CRONICLE_custom_live_log_socket_url='https://cronicle.example.com'

, but I am still getting:

Log Watcher: Server Connect Error: Error: websocket error (https://172.18.0.38:3013)

@lukasmrtvy
Copy link

Ups, sorry, its working with CRONICLE_client__custom_live_log_socket_url

@jhuckaby
Copy link
Owner

@lukasmrtvy No, the thing is, the new custom_live_log_socket_url isn't a top-level configuration property. It lives inside the client object, so you would have to format the environment variable like this:

CRONICLE_client__custom_live_log_socket_url='https://cronicle.example.com'

Notice there are two underscores there (__), which denotes a sub-object traversal. This is explained in the Environment Variables section in the main docs:

For overriding configuration properties by environment variable, you can specify any top-level JSON key from config.json, or a path to a nested property using double-underscore (__) as a path separator. For boolean properties, you can specify 1 for true and 0 for false.

Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants