default FDs to CLOEXEC, expose enable_on_exec #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for setting `enable-on-exec`
Note: this is a behavior change. Currently, this crate opens FDs without CLOEXEC, which means they persist across exec. This is not the convention throughout the Rust ecosystem, which is to do the opposite: rust-lang/rust#24237 This patch setting CLOEXEC :) Note that doing that after-the-fact on the resulting FD isn't quite good enough: if your process is forking a lot, that's racy.
facebook-github-bot
pushed a commit
to facebookexperimental/reverie
that referenced
this pull request
Mar 15, 2023
Summary: For jimblandy/perf-event#29 which sets CLOEXEC by default. Reviewed By: edward-shen Differential Revision: D43983384 Privacy Context Container: L1123788 fbshipit-source-id: 478c0e11bd815e916094b48ce7763b4dfc3e5f79
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Mar 15, 2023
Summary: For jimblandy/perf-event#29 which sets CLOEXEC by default. Reviewed By: edward-shen Differential Revision: D43983384 Privacy Context Container: L1123788 fbshipit-source-id: 478c0e11bd815e916094b48ce7763b4dfc3e5f79
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Mar 15, 2023
Summary: For jimblandy/perf-event#29 which sets CLOEXEC by default. Reviewed By: edward-shen Differential Revision: D43983384 Privacy Context Container: L1123788 fbshipit-source-id: 478c0e11bd815e916094b48ce7763b4dfc3e5f79
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Mar 15, 2023
Summary: For jimblandy/perf-event#29 which sets CLOEXEC by default. Reviewed By: edward-shen Differential Revision: D43983384 Privacy Context Container: L1123788 fbshipit-source-id: 478c0e11bd815e916094b48ce7763b4dfc3e5f79
This adds support for excuding user code, thus measuring only Kernel code.
Phantomical
added a commit
to Phantomical/perf-event
that referenced
this pull request
Apr 14, 2023
This appears to be what the rust stdlib does (see [0]) so following along with their conventions is probably best. This commit was inspired by this pr to perf-event: jimblandy/perf-event#29 [0]: rust-lang/rust#24237
Phantomical
added a commit
to Phantomical/perf-event
that referenced
this pull request
Apr 20, 2023
This appears to be what the rust stdlib does (see [0]) so following along with their conventions is probably best. This commit was inspired by this pr to perf-event: jimblandy/perf-event#29 [0]: rust-lang/rust#24237
Phantomical
added a commit
to Phantomical/perf-event
that referenced
this pull request
Apr 20, 2023
This appears to be what the rust stdlib does (see [0]) so following along with their conventions is probably best. This commit was inspired by this pr to perf-event: jimblandy/perf-event#29 [0]: rust-lang/rust#24237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, thanks for this crate.
Here are couple patches I've been using that I thought you might find useful to merge: