Fix intermittent Win+Arrow handling - #963
Open
greyhair-atx wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Arrow keys could intermittently be interpreted as Windows snap shortcuts while an embedded PuTTY window had focus. The low-level keyboard hook previously inferred modifier state with
GetKeyState, whose results are unreliable inside a low-level keyboard callback, and focus transitions could leave stale modifier state behind.Changes
SendInputinstead of synthesizing Windows-key transitions.dwExtraInfoand ignore only those events, allowing input generated by accessibility and automation software to continue through normal handling.Verification
The Release validation used a separate output directory because an existing SuperPuTTY session had the normal Release executable open.