Allow signing commits by other authors when rewriting them #5408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'signing.sign-all' setting only applies to own commits (i.e. where the author email equals the `user.email`). However, some environments require all commits to be signed, no matter who authored them. To address this need, this commit introduces the additional setting `signing.sign-foreign`, which - in combination with `sign-all` - will ensure that these commits will be signed with the user's configured signing key when rewriting them.
Wuestengecko
changed the title
|
Thanks!
I just added more support for that idea (as you've probably seen already).
Yuya just added better support for that in #5298, so you can probably look at the changes in that PR to figure out what to do. |
|
I have unsent patches to rename+update config values. Maybe I need to push them first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I want to try and get the ball rolling on a fix for #4561, so here's a first shot at it. This simply adds another boolean flag
sign-foreign, which upgradesSignBehavior::OwntoForce. As such, it's a very non-invasive change.The code in this PR is working fine for me locally, but I haven't really looked into automated tests yet.
One proposed alternative is to change it to a
signvariable that takes one of these behavior names. This would require migration or deprecation of the previoussign-allflag, which I haven't figured out how it works yet :)Please let me know what you think about this. I'm also happy to change to a different approach (although it might take me a while, as I'm new to this codebase).
Checklist
If applicable:
CHANGELOG.md