cli: add error stub for jj util mangen
#5528
Conversation
Packagers who are invoking `jj util mangen` will get broken with no advice on how to remediate. Soft-deprecating the command with a warning probably won't help here because package installation is automated, and presumably won't surface those warnings. See the issue linked in the error message string for more detail.
| /// will be removed in a future version. | ||
| Mangen, |
There was a problem hiding this comment.
nit: missing TODO for the removal in jj 0.30+
There was a problem hiding this comment.
Thanks, will add (also I didn't know the next jj version 🤣).
@PhilipMetzger What does "in state" mean? Does this mean the same as "in order", as in "warranted in this situation"?
See the commit message for why I think it's not useful to follow the normal deprecation feature. I was going to do that first, but I don't think it improves anything for package maintainers. |
Yes, that should've been a "a full restore in order".
While it happened with someone who was a packager, we have no data on actual command utilization in the wild. So carving out such a exception for packagers seems really unwise. It also casually breaks our social contract. |
|
This is a packaging command so I think applying norms for packagers makes sense? (Even if someone is “packaging by hand”, they’ll do it once per install, so I don’t think this could break someone’s day‐to‐day workflow.) FWIW as a downstream packager of Jujutsu I would find a hard error for this much more useful than a restored deprecated command. (Is the long deprecation period for every backwards‐incompatible change written down anywhere?) |
| @@ -45,6 +46,9 @@ pub(crate) enum UtilCommand { | |||
| ConfigSchema(UtilConfigSchemaArgs), | |||
| Exec(UtilExecArgs), | |||
| Gc(UtilGcArgs), | |||
| /// No longer supported; use `jj util install-man-pages` instead. This stub | |||
There was a problem hiding this comment.
I feel like this command should be hidden in the Clap sense. This should also remove it from the docs. TODO: Find the right syntax.
There was a problem hiding this comment.
I think adding #[command(hide = true)] here will do it.
There was a problem hiding this comment.
Yes, good point, thanks for raising.
Closes #5525.
Checklist
If applicable:
CHANGELOG.md