github: clean up and consolidate the build matrix #5598
Merged
+127
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also contains an update to use macOS-14 on ARM to build x86 binaries to keep the build matrix more regular. It's still faster than Windows. :') I can pull that out, but I think migrating off macos-13 is probably a good idea in general. |
emilazy
reviewed
Feb 5, 2025
thoughtpolice
force-pushed
the
aseipp/push-vslxsypqtwlv
branch
from
64ae60d to
33960d5
Compare
ilyagr
reviewed
Feb 6, 2025
ilyagr
reviewed
Feb 6, 2025
4 tasks
thoughtpolice
force-pushed
the
aseipp/push-vslxsypqtwlv
branch
3 times, most recently
from
f37007d to
0249c77
Compare
Signed-off-by: Austin Seipp <[email protected]>
Signed-off-by: Austin Seipp <[email protected]>
This makes the methods and the madness a little more consistent with each other, so it's easier to read and categorize build reports in the GHA UX. No functional change, but requires updating rulesets upstream. Signed-off-by: Austin Seipp <[email protected]>
There's no real reason to keep these separate and it makes the build UX easier to navigate, too; as well as see what the actual "global" slowest builds across all workflows easier to see. Signed-off-by: Austin Seipp <[email protected]>
Just a rename; now that `build` and `build-nix` are unified, this makes it more clear this workflow is conceptually separate. NFC. Signed-off-by: Austin Seipp <[email protected]>
Moves all the Windows junk out of the way, where it can be encapsulated. Signed-off-by: Austin Seipp <[email protected]>
'ci' is much more high-level and accurately explains what the jobs in this test should be for. It's much more applicable than 'test' (testing what? on what platforms?) or 'build' (does it only build? or test? or run linters?) Signed-off-by: Austin Seipp <[email protected]>
The CI system is variously hitting the limits of the existing 15 minute build mark; in particular, Windows seems to be consistently hitting ~14m so the chance of a runner timing out gets high if the underlying load is also high. While I'm working on this, let's just (regrettably) increase the slack on the timeout so that everyone else isn't disturbed. Signed-off-by: Austin Seipp <[email protected]>
thoughtpolice
force-pushed
the
aseipp/push-vslxsypqtwlv
branch
from
0249c77 to
0a9f96c
Compare
ilyagr
approved these changes
Feb 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the existing build matrix much more "regular" and makes it easier to navigate by consolidating everything under the main build workflow. Here's an example of the results: https://github.com/jj-vcs/jj/actions/runs/13180977716
This requires a mass rename of all the required checks, so @martinvonz will have to take over.
Checklist
If applicable:
CHANGELOG.md