Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve settings UX a bit #37

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Improve settings UX a bit #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9148f24
Move some options into advanced expander
jjonescz Oct 31, 2024
cb39c9f
Add note about force reloading
jjonescz Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 25 additions & 20 deletions src/App/Lab/Settings.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,26 +42,6 @@
</label>
</div>

@* Debug logs check box *@
<div class="form-check">
<input class="form-check-input" type="checkbox" id="debugLogs"
@bind="DebugLogs" @bind:after="OnSetDebugLogsAsync" />
<label class="form-check-label" for="debugLogs"
title="Whether to display debug-level logs in the browser development console">
Debug logs
</label>
</div>

@* Use a worker check box *@
<div class="form-check">
<input class="form-check-input" type="checkbox" id="enableWorker"
@bind="EnableWorker" @bind:after="OnSetEnableWorkerAsync" />
<label class="form-check-label" for="enableWorker"
title="Moves compilation to a separate worker thread">
Use a worker (requires restart)
</label>
</div>

@* Language services check box *@
<div class="form-check">
<input class="form-check-input" type="checkbox" id="enableLanguageServices"
Expand All @@ -73,6 +53,30 @@
</label>
</div>

<details class="mt-2">
<summary>Advanced</summary>

@* Debug logs check box *@
<div class="form-check mt-2">
<input class="form-check-input" type="checkbox" id="debugLogs"
@bind="DebugLogs" @bind:after="OnSetDebugLogsAsync" />
<label class="form-check-label" for="debugLogs"
title="Whether to display debug-level logs in the browser development console">
Debug logs
</label>
</div>

@* Use a worker check box *@
<div class="form-check">
<input class="form-check-input" type="checkbox" id="enableWorker"
@bind="EnableWorker" @bind:after="OnSetEnableWorkerAsync" />
<label class="form-check-label" for="enableWorker"
title="Moves compilation (and language services if enabled) to a separate worker thread (it is recommended to keep this enabled)">
Compile in a background worker thread (requires restart)
</label>
</div>
</details>

<h6 class="mt-3 h5">Compilers</h6>

@* SDK version select *@
Expand Down Expand Up @@ -211,6 +215,7 @@
<div class="alert alert-info" role="alert">
<strong>An update is available.</strong>
Close all app tabs and reopen to activate the update.
Force reloading (<kbd>Shift</kbd> + <kbd>F5</kbd>) can be used temporarily for the current tab.
</div>
}
</div>
Expand Down