Fix/multi domain generation#22
Merged
Merged
Conversation
added 2 commits
February 13, 2026 10:43
The ClassSchemaResolver singleton cache persisted across domain runs while SchemaRegistry was reset between them. This caused nested $ref schemas to point to components that were never re-registered in the fresh registry, resulting in broken references in the second domain's spec output.
Routes without a #[DocumentationFile] attribute default to ['default']. The filter was including these in every documentation file because it checked `docFiles contains requestedFile OR docFiles contains 'default'`. This caused all internal routes to leak into non-default specs like the public API documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as a singleton but its cache was never cleared between domain runs. When SchemaRegistry was reset for
the next domain, nested $ref schemas pointed to components that were never re-registered. Added
reset() to ClassSchemaResolver and call it alongside $registry->reset() in the generate command.
attribute default to ['default']. The discovery filter included routes if they matched the requested
file OR had 'default', causing all internal routes to appear in every spec. Removed the 'default'
fallback so only explicitly assigned routes are included.