Break after until #354
Open
Break after until #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
==========================================
+ Coverage 90.06% 90.07% +0.01%
==========================================
Files 28 28
Lines 1962 1964 +2
Branches 583 585 +2
==========================================
+ Hits 1767 1769 +2
Misses 195 195
Continue to review full report at Codecov.
|
davidgoli
reviewed
Jul 19, 2019
src/iter/index.ts
Outdated
| return emitResult(iterResult) | ||
| if (counterDate) { | ||
|
|
||
| if (counterDate.year > endYear) { |
There was a problem hiding this comment.
Please collapse these 2 if statements into if (counterDate && counterDate.year > endYear)
There was a problem hiding this comment.
I think you should take it despite that now no?
davidgoli
requested changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Daily repeating entries can hang the browser when querying between.
Fix to use the until parameter to prevent this happening
Thanks for contributing to
rrule!To submit a pull request, please verify that you have done the following:
mastercommitaddressing