Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for byhour and byminute (HH:MM) text parsing for daily #398

Closed
wants to merge 1 commit into from

Conversation

dan-kez
Copy link

@dan-kez dan-kez commented May 13, 2020

Added functionality:

  • Support at HH:MM where minutes are optional for the daily case
'Every day at 9:10' =>  'RRULE:FREQ=DAILY;BYHOUR=9;BYMINUTE=10'
'Every day at 23:00, 23:30, 9:00 and 9:30' =>  'RRULE:FREQ=DAILY;BYHOUR=23,9;BYMINUTE=0,30'

This partially solves #387. While this issue is primarily about the monthly & weekly cases the same issue persists with the daily case.

I plan on having a subsequent PR that will make this applicable for byweekly and monthly assuming the minute parsing is accepted.|


Thanks for contributing to rrule!

To submit a pull request, please verify that you have done the following:

  • Merged in or rebased on the latest master commit
  • Linked to an existing bug or issue describing the bug or feature you're
    addressing
  • Written one or more tests showing that your change works as advertised

@dan-kez
Copy link
Author

dan-kez commented May 13, 2020

Looking at #388 - their implementation is much better and should be taken instead of this PR.

@dan-kez dan-kez closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant