Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically refresh credentials #17

Merged
merged 3 commits into from
Nov 30, 2024
Merged

Automatically refresh credentials #17

merged 3 commits into from
Nov 30, 2024

Conversation

jlewi
Copy link
Owner

@jlewi jlewi commented Nov 30, 2024

Automatically refresh at proto credentials.

The implementation isn't the most elegant. It would be nicer to do this in a more transparent way; e.g. using a RoundTripper or following the pattern of OAuth libraries that automatically refresh the credential everytime you call Token if necessary.

The current implementation uses our existing xrpc manager and fetches a new client with refreshed credentials if necessary.

  • Also add a command to dump lists to a file
  • So we can verify that a list is up to date.

@jlewi jlewi merged commit 480b2bf into main Nov 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant