Skip to content

Commit

Permalink
feat(logger): separate out the cli
Browse files Browse the repository at this point in the history
  • Loading branch information
jmcdo29 committed Jan 24, 2021
1 parent 34425fb commit 6b61663
Show file tree
Hide file tree
Showing 40 changed files with 17,144 additions and 495 deletions.
21 changes: 11 additions & 10 deletions benchmarks/interceptor/README.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
# OgmaInterceptor Benchmarks

- Benchmarks were made by setting up identical NestJS applications and attaching either the OgmaModule or [morgan](https://npmjs.org/morgan) via `app.use()`.
- These benchmarks were only ran for an Express server, as morgan is only configured to work for Express servers.
- Each request was made 10 time, and the time shown is the average response time for each request type.
* Benchmarks were made by setting up identical NestJS applications and attaching either the OgmaModule or [morgan](https://npmjs.org/morgan) via `app.use()`.
* These benchmarks were only ran for an Express server, as morgan is only configured to work for Express servers.
* Each request was made 10 time, and the time shown is the average response time for each request type.

## Results

| Request Logger | GET | POST | PUT | PATCH | DELETE |
| -------------- | ------ | ------ | ------ | ------ | ------ |
| ogma | 6 ms | 5.3 ms | 6.1 ms | 5.3 ms | 5.1 ms |
| morganDev | 5.5 ms | 5.5 ms | 6.1 ms | 5.2 ms | 4.9 ms |
| morganCombined | 5.6 ms | 5.5 ms | 6 ms | 5.3 ms | 5 ms |
| none | 5.7 ms | 5.4 ms | 6.2 ms | 5.2 ms | 5.1 ms |
| Request Logger | GET | POST | PUT | PATCH | DELETE |
| - | - | - | - | - | - |
| ogma | 7.6 ms | 6.4 ms | 5.3 ms | 5.9 ms | 5 ms |
| morganDev | 6.8 ms | 6.1 ms | 5.6 ms | 6.1 ms | 5.2 ms |
| morganCombined | 7 ms | 5.9 ms | 5.5 ms | 6.4 ms | 4.8 ms |
| none | 7.3 ms | 6 ms | 5.5 ms | 6.2 ms | 5.1 ms |


## Information

Benchmarks generated on Linux/linux x64 5.4.0-47-generic ~Intel(R) Core(TM) i3-8130U CPU @ 2.20GHz (cores/threads): 4
Benchmarks generated on Darwin/darwin x64 19.6.0 ~Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (cores/threads): 12
17 changes: 17 additions & 0 deletions benchmarks/interceptor/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"name": "@ogma/benchmark-interceptor",
"version": "0.0.0",
"private": true,
"scripts": {
"start": "nest start"
},
"dependencies": {
"@nestjs/common": "^7.6.5",
"@nestjs/core": "^7.5.4",
"morgan": "1.10.0",
"@nestjs/platform-express": "^7.5.4",
"@ogma/nestjs-module": "workspace:*",
"@ogma/platform-express": "workspace:*",
"@nestjs/cli": "^7.5.4"
}
}
3 changes: 3 additions & 0 deletions benchmarks/interceptor/tsconfig.build.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": "./tsconfig.json"
}
13 changes: 7 additions & 6 deletions benchmarks/logger/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ Benchmarks were made by testing the logging capabilities of several loggers agai
## Results

| Logger | Simple | Long | JSON | Deep |
| --- | --- | --- | --- | --- |
| Bunyan | 354.955363ms | 4067.132908ms | 804.267905ms | 1287.702897ms |
| Ogma | 260.002731ms | 1938.668793ms | 289.710806ms | 398.153038ms |
| Pino | 139.931047ms | 5255.606637ms | 406.781887ms | 2781.67296ms |
| Winston | 462.864598ms | 5052.486821ms | 3371.397049ms | 1742.606749ms |
| - | - | - | - | - |
| Bunyan | 365.639714ms | 3366.430737ms | 402.997234ms | 872.559683ms |
| Ogma | 197.048245ms | 1707.446041ms | 624.110164ms | 444.304243ms |
| Pino | 158.316033ms | 4742.960689ms | 207.18999ms | 241.351321ms |
| Winston | 372.207588ms | 4704.382725ms | 482.269369ms | 517.493435ms |


## Information

Benchmarks generated on Linux/linux x64 5.4.0-47-generic ~Intel(R) Core(TM) i3-8130U CPU @ 2.20GHz (cores/threads): 4
Benchmarks generated on Darwin/darwin x64 19.6.0 ~Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (cores/threads): 12
15 changes: 15 additions & 0 deletions benchmarks/logger/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"name": "@ogma/benchmark-logger",
"version": "0.0.0",
"private": true,
"scripts": {
"start": "rimraf dist && tsc -p tsconfig.json && node dist/index"
},
"dependencies": {
"pino": "6.11.0",
"bunyan": "1.8.15",
"winston": "3.3.3",
"@ogma/logger": "workspace:*",
"rimraf": "3.0.2"
}
}
5 changes: 5 additions & 0 deletions coverage-tmp/cli-coverage.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{"/home/jay/Documents/code/projects/ogma/packages/cli/src/file.service.ts": {"path":"/home/jay/Documents/code/projects/ogma/packages/cli/src/file.service.ts","statementMap":{"0":{"start":{"line":1,"column":0},"end":{"line":1,"column":44}},"1":{"start":{"line":2,"column":0},"end":{"line":2,"column":30}},"2":{"start":{"line":5,"column":0},"end":{"line":9,"column":null}},"3":{"start":{"line":7,"column":4},"end":{"line":7,"column":58}},"4":{"start":{"line":5,"column":13},"end":{"line":9,"column":null}},"5":{"start":{"line":5,"column":13},"end":{"line":5,"column":24}}},"fnMap":{"0":{"name":"(anonymous_1)","decl":{"start":{"line":6,"column":2},"end":{"line":6,"column":7}},"loc":{"start":{"line":6,"column":29},"end":{"line":8,"column":3}}}},"branchMap":{},"s":{"0":1,"1":1,"2":1,"3":112,"4":1,"5":1},"f":{"0":112},"b":{}}
,"/home/jay/Documents/code/projects/ogma/packages/cli/src/messages.ts": {"path":"/home/jay/Documents/code/projects/ogma/packages/cli/src/messages.ts","statementMap":{"0":{"start":{"line":1,"column":13},"end":{"line":1,"column":69}},"1":{"start":{"line":2,"column":13},"end":{"line":3,"column":80}}},"fnMap":{},"branchMap":{},"s":{"0":1,"1":1},"f":{},"b":{}}
,"/home/jay/Documents/code/projects/ogma/packages/cli/src/ogma-getters.service.ts": {"path":"/home/jay/Documents/code/projects/ogma/packages/cli/src/ogma-getters.service.ts","statementMap":{"0":{"start":{"line":1,"column":0},"end":{"line":1,"column":44}},"1":{"start":{"line":2,"column":0},"end":{"line":2,"column":47}},"2":{"start":{"line":3,"column":0},"end":{"line":3,"column":53}},"3":{"start":{"line":7,"column":0},"end":{"line":55,"column":null}},"4":{"start":{"line":9,"column":4},"end":{"line":9,"column":47}},"5":{"start":{"line":13,"column":4},"end":{"line":32,"column":null}},"6":{"start":{"line":15,"column":8},"end":{"line":15,"column":30}},"7":{"start":{"line":16,"column":8},"end":{"line":16,"column":14}},"8":{"start":{"line":18,"column":8},"end":{"line":18,"column":28}},"9":{"start":{"line":19,"column":8},"end":{"line":19,"column":14}},"10":{"start":{"line":21,"column":8},"end":{"line":21,"column":27}},"11":{"start":{"line":22,"column":8},"end":{"line":22,"column":14}},"12":{"start":{"line":24,"column":8},"end":{"line":24,"column":27}},"13":{"start":{"line":25,"column":8},"end":{"line":25,"column":14}},"14":{"start":{"line":27,"column":8},"end":{"line":27,"column":29}},"15":{"start":{"line":28,"column":8},"end":{"line":28,"column":14}},"16":{"start":{"line":31,"column":8},"end":{"line":31,"column":26}},"17":{"start":{"line":33,"column":4},"end":{"line":33,"column":17}},"18":{"start":{"line":37,"column":4},"end":{"line":37,"column":33}},"19":{"start":{"line":38,"column":4},"end":{"line":40,"column":null}},"20":{"start":{"line":39,"column":6},"end":{"line":39,"column":36}},"21":{"start":{"line":41,"column":4},"end":{"line":41,"column":15}},"22":{"start":{"line":45,"column":4},"end":{"line":45,"column":22}},"23":{"start":{"line":49,"column":20},"end":{"line":49,"column":59}},"24":{"start":{"line":50,"column":4},"end":{"line":52,"column":null}},"25":{"start":{"line":51,"column":6},"end":{"line":51,"column":68}},"26":{"start":{"line":53,"column":4},"end":{"line":53,"column":21}},"27":{"start":{"line":7,"column":13},"end":{"line":55,"column":null}},"28":{"start":{"line":7,"column":13},"end":{"line":7,"column":30}}},"fnMap":{"0":{"name":"(anonymous_1)","decl":{"start":{"line":8,"column":2},"end":{"line":8,"column":12}},"loc":{"start":{"line":8,"column":55},"end":{"line":10,"column":3}}},"1":{"name":"(anonymous_2)","decl":{"start":{"line":11,"column":2},"end":{"line":11,"column":15}},"loc":{"start":{"line":11,"column":44},"end":{"line":34,"column":3}}},"2":{"name":"(anonymous_3)","decl":{"start":{"line":36,"column":2},"end":{"line":36,"column":8}},"loc":{"start":{"line":36,"column":53},"end":{"line":42,"column":3}}},"3":{"name":"(anonymous_4)","decl":{"start":{"line":44,"column":2},"end":{"line":44,"column":14}},"loc":{"start":{"line":44,"column":26},"end":{"line":46,"column":3}}},"4":{"name":"(anonymous_5)","decl":{"start":{"line":48,"column":2},"end":{"line":48,"column":10}},"loc":{"start":{"line":48,"column":58},"end":{"line":54,"column":3}}}},"branchMap":{"0":{"loc":{"start":{"line":9,"column":11},"end":{"line":9,"column":22}},"type":"binary-expr","locations":[{"start":{"line":9,"column":11},"end":{"line":9,"column":22}},{"start":{"line":9,"column":26},"end":{"line":9,"column":46}}]},"1":{"loc":{"start":{"line":14,"column":6},"end":{"line":16,"column":14}},"type":"switch","locations":[{"start":{"line":14,"column":6},"end":{"line":16,"column":14}},{"start":{"line":17,"column":6},"end":{"line":19,"column":14}},{"start":{"line":20,"column":6},"end":{"line":22,"column":14}},{"start":{"line":23,"column":6},"end":{"line":25,"column":14}},{"start":{"line":26,"column":6},"end":{"line":28,"column":14}},{"start":{"line":29,"column":6},"end":{"line":29,"column":19}},{"start":{"line":30,"column":6},"end":{"line":31,"column":26}}]},"2":{"loc":{"start":{"line":38,"column":4},"end":{"line":40,"column":null}},"type":"if","locations":[{"start":{"line":38,"column":4},"end":{"line":40,"column":null}},{"start":{"line":38,"column":4},"end":{"line":40,"column":null}}]},"3":{"loc":{"start":{"line":50,"column":4},"end":{"line":52,"column":null}},"type":"if","locations":[{"start":{"line":50,"column":4},"end":{"line":52,"column":null}},{"start":{"line":50,"column":4},"end":{"line":52,"column":null}}]}},"s":{"0":1,"1":1,"2":1,"3":1,"4":112,"5":56,"6":8,"7":8,"8":8,"9":8,"10":8,"11":8,"12":8,"13":8,"14":8,"15":8,"16":16,"17":56,"18":224,"19":224,"20":112,"21":224,"22":448,"23":112,"24":112,"25":56,"26":112,"27":1,"28":1},"f":{"0":112,"1":56,"2":224,"3":448,"4":112},"b":{"0":[112,56],"1":[8,8,8,8,8,8,16],"2":[112,112],"3":[56,56]}}
,"/home/jay/Documents/code/projects/ogma/packages/cli/src/ogma.command.ts": {"path":"/home/jay/Documents/code/projects/ogma/packages/cli/src/ogma.command.ts","statementMap":{"0":{"start":{"line":1,"column":0},"end":{"line":1,"column":64}},"1":{"start":{"line":2,"column":0},"end":{"line":2,"column":37}},"2":{"start":{"line":3,"column":0},"end":{"line":3,"column":45}},"3":{"start":{"line":4,"column":0},"end":{"line":4,"column":39}},"4":{"start":{"line":6,"column":0},"end":{"line":6,"column":59}},"5":{"start":{"line":17,"column":0},"end":{"line":72,"column":null}},"6":{"start":{"line":19,"column":21},"end":{"line":19,"column":34}},"7":{"start":{"line":20,"column":21},"end":{"line":20,"column":33}},"8":{"start":{"line":22,"column":10},"end":{"line":22,"column":46}},"9":{"start":{"line":25,"column":17},"end":{"line":25,"column":47}},"10":{"start":{"line":26,"column":4},"end":{"line":28,"column":null}},"11":{"start":{"line":26,"column":29},"end":{"line":26,"column":54}},"12":{"start":{"line":27,"column":6},"end":{"line":27,"column":33}},"13":{"start":{"line":29,"column":4},"end":{"line":29,"column":100}},"14":{"start":{"line":29,"column":22},"end":{"line":29,"column":37}},"15":{"start":{"line":29,"column":65},"end":{"line":29,"column":98}},"16":{"start":{"line":38,"column":4},"end":{"line":38,"column":40}},"17":{"start":{"line":42,"column":4},"end":{"line":42,"column":84}},"18":{"start":{"line":42,"column":79},"end":{"line":42,"column":82}},"19":{"start":{"line":46,"column":4},"end":{"line":50,"column":null}},"20":{"start":{"line":47,"column":6},"end":{"line":47,"column":48}},"21":{"start":{"line":49,"column":6},"end":{"line":49,"column":19}},"22":{"start":{"line":54,"column":4},"end":{"line":54,"column":88}},"23":{"start":{"line":54,"column":40},"end":{"line":54,"column":86}},"24":{"start":{"line":58,"column":74},"end":{"line":58,"column":77}},"25":{"start":{"line":58,"column":69},"end":{"line":58,"column":74}},"26":{"start":{"line":59,"column":21},"end":{"line":59,"column":61}},"27":{"start":{"line":60,"column":4},"end":{"line":60,"column":63}},"28":{"start":{"line":61,"column":4},"end":{"line":61,"column":79}},"29":{"start":{"line":62,"column":4},"end":{"line":64,"column":null}},"30":{"start":{"line":63,"column":6},"end":{"line":63,"column":83}},"31":{"start":{"line":65,"column":4},"end":{"line":65,"column":28}},"32":{"start":{"line":66,"column":4},"end":{"line":68,"column":null}},"33":{"start":{"line":67,"column":6},"end":{"line":67,"column":77}},"34":{"start":{"line":69,"column":4},"end":{"line":69,"column":63}},"35":{"start":{"line":70,"column":4},"end":{"line":70,"column":50}},"36":{"start":{"line":37,"column":2},"end":{"line":39,"column":null}},"37":{"start":{"line":17,"column":13},"end":{"line":72,"column":null}},"38":{"start":{"line":17,"column":13},"end":{"line":17,"column":24}}},"fnMap":{"0":{"name":"(anonymous_3)","decl":{"start":{"line":18,"column":2},"end":{"line":18,"column":null}},"loc":{"start":{"line":20,"column":50},"end":{"line":21,"column":6}}},"1":{"name":"(anonymous_4)","decl":{"start":{"line":24,"column":2},"end":{"line":24,"column":7}},"loc":{"start":{"line":24,"column":57},"end":{"line":30,"column":3}}},"2":{"name":"(anonymous_5)","decl":{"start":{"line":26,"column":20},"end":{"line":26,"column":21}},"loc":{"start":{"line":26,"column":29},"end":{"line":26,"column":54}}},"3":{"name":"(anonymous_6)","decl":{"start":{"line":29,"column":13},"end":{"line":29,"column":14}},"loc":{"start":{"line":29,"column":22},"end":{"line":29,"column":37}}},"4":{"name":"(anonymous_7)","decl":{"start":{"line":29,"column":47},"end":{"line":29,"column":48}},"loc":{"start":{"line":29,"column":65},"end":{"line":29,"column":98}}},"5":{"name":"(anonymous_8)","decl":{"start":{"line":37,"column":2},"end":{"line":37,"column":14}},"loc":{"start":{"line":37,"column":27},"end":{"line":39,"column":3}}},"6":{"name":"(anonymous_9)","decl":{"start":{"line":41,"column":10},"end":{"line":41,"column":15}},"loc":{"start":{"line":41,"column":41},"end":{"line":43,"column":3}}},"7":{"name":"(anonymous_10)","decl":{"start":{"line":42,"column":70},"end":{"line":42,"column":71}},"loc":{"start":{"line":42,"column":79},"end":{"line":42,"column":82}}},"8":{"name":"(anonymous_11)","decl":{"start":{"line":45,"column":10},"end":{"line":45,"column":25}},"loc":{"start":{"line":45,"column":37},"end":{"line":51,"column":3}}},"9":{"name":"(anonymous_12)","decl":{"start":{"line":53,"column":10},"end":{"line":53,"column":22}},"loc":{"start":{"line":53,"column":47},"end":{"line":55,"column":3}}},"10":{"name":"(anonymous_13)","decl":{"start":{"line":54,"column":31},"end":{"line":54,"column":32}},"loc":{"start":{"line":54,"column":40},"end":{"line":54,"column":86}}},"11":{"name":"(anonymous_14)","decl":{"start":{"line":57,"column":10},"end":{"line":57,"column":18}},"loc":{"start":{"line":57,"column":47},"end":{"line":71,"column":3}}}},"branchMap":{"0":{"loc":{"start":{"line":26,"column":4},"end":{"line":28,"column":null}},"type":"if","locations":[{"start":{"line":26,"column":4},"end":{"line":28,"column":null}},{"start":{"line":26,"column":4},"end":{"line":28,"column":null}}]},"1":{"loc":{"start":{"line":38,"column":17},"end":{"line":38,"column":32}},"type":"cond-expr","locations":[{"start":{"line":38,"column":17},"end":{"line":38,"column":32}},{"start":{"line":38,"column":35},"end":{"line":38,"column":39}}]},"2":{"loc":{"start":{"line":62,"column":4},"end":{"line":64,"column":null}},"type":"if","locations":[{"start":{"line":62,"column":4},"end":{"line":64,"column":null}},{"start":{"line":62,"column":4},"end":{"line":64,"column":null}}]},"3":{"loc":{"start":{"line":66,"column":4},"end":{"line":68,"column":null}},"type":"if","locations":[{"start":{"line":66,"column":4},"end":{"line":68,"column":null}},{"start":{"line":66,"column":4},"end":{"line":68,"column":null}}]}},"s":{"0":1,"1":1,"2":1,"3":1,"4":1,"5":1,"6":112,"7":112,"8":112,"9":112,"10":112,"11":112,"12":0,"13":112,"14":112,"15":112,"16":0,"17":112,"18":112,"19":112,"20":112,"21":0,"22":112,"23":336,"24":112,"25":112,"26":112,"27":112,"28":112,"29":112,"30":56,"31":112,"32":112,"33":56,"34":112,"35":112,"36":1,"37":1,"38":1},"f":{"0":112,"1":112,"2":112,"3":112,"4":112,"5":0,"6":112,"7":112,"8":112,"9":112,"10":336,"11":112},"b":{"0":[0,112],"1":[0,0],"2":[56,56],"3":[56,56]}}
}
Loading

0 comments on commit 6b61663

Please sign in to comment.