Refactor logging system to use Hive for log storage and metadata managment. #1016
Conversation
…gement; add metadata helper for device and app information
|
@Chaphasilor I don't know, I changed the target branch |
|
I can't test it out myself |
…ate log sharing process to include metadata files and adjust setup locator for dependency registration.
|
|
||
| void main() async { | ||
| // If the app has failed, this is set to true. If true, we don't attempt to run the main app since the error app has started. | ||
| bool hasFailed = false; | ||
| try { | ||
| await setupLocator(); |
There was a problem hiding this comment.
please either namespace this (import 'services/metadata_helper.dart' as metadataHelper; and then await metadataHelper.setupLocator()), or move the setup function to main.dart (like all the other setup functions).
| getIt.registerLazySingleton(() => DeviceInfo()); | ||
| getIt.registerLazySingleton(() => AppInfo()); | ||
| getIt.registerLazySingleton(() => ServerInfo()); | ||
| getIt.registerLazySingleton(() => MetaData()); |
There was a problem hiding this comment.
I don't think it's necessary to register four new global singletons. The MetaData class should be enough, and you could add any methods that need to be accessed into it. Or provide getters for the other classes through MetaData.
Also, maybe rename it to MetaDataHelper?
| } | ||
| startupLogger.info("Running on $deviceInfoString."); | ||
| startupLogger.info( | ||
| "This is ${packageInfo.version} version ${packageInfo.version}+${packageInfo.originallyInstalledVersion} (Signature '${packageInfo.installationDate}'), installed via ${packageInfo.updateHistory}."); |
There was a problem hiding this comment.
Please don't change the information that is logged. The missing information (like appName, buildNumber, etc. should be added to the AppInfo class)
| WindowsDeviceInfo windowsInfo = await deviceInfo.windowsInfo; | ||
| osVersion = windowsInfo.displayVersion; | ||
| deviceModel = windowsInfo.deviceId; | ||
| deviceType = "PC"; // You can add more logic to determine the device type |
There was a problem hiding this comment.
how about you just add platform instead of device type, and set them accordingly (Android, Windows, Linux, etc.)?
| return { | ||
| "appInfo": appInfo.toJson(), | ||
| "serverInfo": serverInfo.toJson(), | ||
| "deviceInfo": deviceInfo.toJson(), | ||
| }; |
There was a problem hiding this comment.
This doesn't generate JSON. The resulting string has no quotes at all. Please use the @JsonSerializable annotation and toJSON method like it's done in finamp_models.dart. You'll have to run code generation after adding the annotation. You can do that by running dart run build_runner build --delete-conflicting-outputs.
the Setup_loggin.dart now uses the metadata_helper.dart to fetch info